Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add federation share type #60

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add federation share type #60

merged 1 commit into from
Mar 7, 2023

Conversation

smesterheide
Copy link
Contributor

This PR intends to add a new share type named federation. This share type is used over the group share type to indicate to the consumer that the share is simultaneously created at multiple services with the same identifier. The consumer may allow the share to be created first with users joining the federated group later on.

@smesterheide smesterheide mentioned this pull request Feb 20, 2023
Closed
3 tasks
michielbdejong
michielbdejong approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I think this would work. And a very minimal change, great!
I can add support for this in OC-10, along with owncloud/core#40589. Would be good to get some buy-in from the CERNBox team before merging this.

glpatcern
glpatcern approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@michielbdejong
Copy link
Contributor

@glpatcern do you know who could help add this functionality to OCIS?

@glpatcern
Copy link
Member

@glpatcern do you know who could help add this functionality to OCIS?

For the moment it's "us", ownCloud will first have to import the basic OCM implementation in OCIS prior to get here. For the context, OCIS is based on Reva's edge branch, which does not implement OCM at all.

@michielbdejong
Copy link
Contributor

michielbdejong commented Feb 20, 2023 •
edited
Loading

One side note (this also came up in the SURF project about federated groups and I also remember discussing this with @andreasfk in 2021):
Apart from allowing a member of a federation ("federated group" / "virtual organisation") to share a folder or other resource with the other members, it would be cool to be able to attach a sort of "group drive" that doesn't have any particular group member as its owner/sender, but just belongs to the group.
This is relevant for instance when the person who created the group folder leaves the group, the group folder should just stay and not be deleted. Similar to a "network drive" or "shared drive".

@smesterheide
Copy link
Contributor Author

Thanks @michielbdejong and @glpatcern for the swift response!

@glpatcern
Copy link
Member

As we've seen this today demonstrated at CS3 Barcelona by Nextcloud, I'm taking the liberty to merge it.

@glpatcern glpatcern merged commit 7d21ed4 into cs3org:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@michielbdejong michielbdejong michielbdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smesterheide @michielbdejong @glpatcern